|author||Boris Kolpackov <email@example.com>||2014-11-26 07:44:46 +0200|
|committer||Boris Kolpackov <firstname.lastname@example.org>||2014-11-26 07:44:46 +0200|
Add quality: move change callback out of image
1 files changed, 14 insertions, 0 deletions
diff --git a/quality/list b/quality/list
index 2ef008a..b7f0e0f 100644
@@ -1 +1,15 @@
- Inconsistent id() vs direct access use in generated code
+? Move change_callback out of image
+ We incur a bit of overhead in case of a batch (e.g., ~80KB for
+ a batch size of 5000 on 64-bit) since we don't use this callback
+ in all but the first element.
+ The idea is to move it to the object statements, however, there
+ are several places that need to access it that only got the image
+ (e.g., init(image)). Storing a pointer in the image doesn't make
+ sense since the struct itself is two pointers.
+ So it is not clear this is worth the effort. See also a separate
+ paper with some more thoughts on this.