From 9b3f696b9643572ad41acda698da2d969c9b264f Mon Sep 17 00:00:00 2001 From: Boris Kolpackov Date: Wed, 26 Nov 2014 07:44:46 +0200 Subject: Add quality: move change callback out of image --- quality/list | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/quality/list b/quality/list index 2ef008a..b7f0e0f 100644 --- a/quality/list +++ b/quality/list @@ -1 +1,15 @@ - Inconsistent id() vs direct access use in generated code + +? Move change_callback out of image + + We incur a bit of overhead in case of a batch (e.g., ~80KB for + a batch size of 5000 on 64-bit) since we don't use this callback + in all but the first element. + + The idea is to move it to the object statements, however, there + are several places that need to access it that only got the image + (e.g., init(image)). Storing a pointer in the image doesn't make + sense since the struct itself is two pointers. + + So it is not clear this is worth the effort. See also a separate + paper with some more thoughts on this. -- cgit v1.1