diff options
author | Boris Kolpackov <boris@codesynthesis.com> | 2013-09-28 10:51:12 +0200 |
---|---|---|
committer | Boris Kolpackov <boris@codesynthesis.com> | 2013-09-28 10:51:12 +0200 |
commit | e28fe11ef1a582f14261e063f162e6088a6816a0 (patch) | |
tree | 84bc636d15d722f134f5c76cec7429d34e1f4c18 /odb/oracle/statements-base.hxx | |
parent | 2159b67ef61613b365deabcfbb7f224438612a54 (diff) |
Make schema version access (but not modification) thread-safe
Also cache the version in statements so that we don't have to lock
the mutex (slow) every time we need to check the version.
Diffstat (limited to 'odb/oracle/statements-base.hxx')
-rw-r--r-- | odb/oracle/statements-base.hxx | 24 |
1 files changed, 19 insertions, 5 deletions
diff --git a/odb/oracle/statements-base.hxx b/odb/oracle/statements-base.hxx index c7227bf..b4cad98 100644 --- a/odb/oracle/statements-base.hxx +++ b/odb/oracle/statements-base.hxx @@ -7,10 +7,12 @@ #include <odb/pre.hxx> +#include <odb/schema-version.hxx> #include <odb/details/shared-ptr.hxx> #include <odb/oracle/version.hxx> -#include <odb/oracle/forward.hxx> // connection +#include <odb/oracle/connection.hxx> +#include <odb/oracle/database.hxx> #include <odb/oracle/details/export.hxx> @@ -29,18 +31,30 @@ namespace odb return conn_; } + // Schema version. database::schema_version_migration() is thread- + // safe which means it is also slow. Cache the result in statements + // so we can avoid the mutex lock. This is thread-safe since if the + // version is updated, then the statements cache will be expired. + // + const schema_version_migration& + version_migration (const char* name = "") const + { + if (svm_ == 0) + svm_ = &conn_.database ().schema_version_migration (name); + + return *svm_; + } + public: virtual ~statements_base (); protected: - statements_base (connection_type& conn) - : conn_ (conn) - { - } + statements_base (connection_type& conn): conn_ (conn), svm_ (0) {} protected: connection_type& conn_; + mutable const schema_version_migration* svm_; }; } } |