Improve the Oracle translate_error implementation

The improved implementation scans all the records associated with an error
handle. Furthermore, if it is established that the connection to the database
has been lost, the connection is marked as such. Additionally, all special
exceptions (deadlock, timeout, and connection_lost) are now supported.

1 files changed, 5 insertions, 8 deletions

diff --git a/odb/oracle/error.hxx b/odb/oracle/error.hxx
index 43a314d..a5dbb10 100644
--- a/odb/oracle/error.hxx
+++ b/odb/oracle/error.hxx
@@ -10,6 +10,7 @@
 
 #include <oci.h>
 
+#include <odb/oracle/forward.hxx>
 #include <odb/oracle/version.hxx>
 #include <odb/oracle/details/export.hxx>
 
@@ -18,19 +19,15 @@ namespace odb
   namespace oracle
   {
     void
-    translate_error (void* h, ub4 t, sword s);
-
-    // @@ Check connection state attribute once connection has been
-    // implemented.
-    //
+    translate_error (void* h, ub4 t, sword s, connection*);
 
     // Translate OCI error given an error handle and throw an appropriate
     // exception.
     //
     inline LIBODB_ORACLE_EXPORT void
-    translate_error (OCIError* h, sword s)
+    translate_error (OCIError* h, sword s, connection* c = 0)
     {
-      translate_error (h, OCI_HTYPE_ERROR, s);
+      translate_error (h, OCI_HTYPE_ERROR, s, c);
     }
 
     // Translate an OCI error given an environment handle error and throw
@@ -39,7 +36,7 @@ namespace odb
     inline LIBODB_ORACLE_EXPORT void
     translate_error (OCIEnv* h)
     {
-      translate_error (h, OCI_HTYPE_ENV, OCI_ERROR);
+      translate_error (h, OCI_HTYPE_ENV, OCI_ERROR, 0);
     }
   }
 }