diff options
author | Boris Kolpackov <boris@codesynthesis.com> | 2013-09-28 10:51:12 +0200 |
---|---|---|
committer | Boris Kolpackov <boris@codesynthesis.com> | 2013-09-28 10:51:12 +0200 |
commit | 29f048816a31422685c44085ac20e45d97f95ecf (patch) | |
tree | db49f030da3ee5c6598e03ee5f273381a838dc7b /odb/sqlite/statements-base.hxx | |
parent | 0392ff4895fed7eb6a3f6befd53a07a7cd9990b4 (diff) |
Make schema version access (but not modification) thread-safe
Also cache the version in statements so that we don't have to lock
the mutex (slow) every time we need to check the version.
Diffstat (limited to 'odb/sqlite/statements-base.hxx')
-rw-r--r-- | odb/sqlite/statements-base.hxx | 24 |
1 files changed, 19 insertions, 5 deletions
diff --git a/odb/sqlite/statements-base.hxx b/odb/sqlite/statements-base.hxx index 5db1369..1df53cd 100644 --- a/odb/sqlite/statements-base.hxx +++ b/odb/sqlite/statements-base.hxx @@ -7,10 +7,12 @@ #include <odb/pre.hxx> +#include <odb/schema-version.hxx> #include <odb/details/shared-ptr.hxx> #include <odb/sqlite/version.hxx> -#include <odb/sqlite/forward.hxx> // connection +#include <odb/sqlite/connection.hxx> +#include <odb/sqlite/database.hxx> #include <odb/sqlite/details/export.hxx> @@ -29,18 +31,30 @@ namespace odb return conn_; } + // Schema version. database::schema_version_migration() is thread- + // safe which means it is also slow. Cache the result in statements + // so we can avoid the mutex lock. This is thread-safe since if the + // version is updated, then the statements cache will be expired. + // + const schema_version_migration& + version_migration (const char* name = "") const + { + if (svm_ == 0) + svm_ = &conn_.database ().schema_version_migration (name); + + return *svm_; + } + public: virtual ~statements_base (); protected: - statements_base (connection_type& conn) - : conn_ (conn) - { - } + statements_base (connection_type& conn): conn_ (conn), svm_ (0) {} protected: connection_type& conn_; + mutable const schema_version_migration* svm_; }; } } |