aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBoris Kolpackov <boris@codesynthesis.com>2012-10-29 16:33:00 +0200
committerBoris Kolpackov <boris@codesynthesis.com>2012-10-29 16:33:00 +0200
commit2eac10b0aae159bdfc249c67f11b32a65036352d (patch)
tree681a0f2d7c2cbbe5306dd1a4c1bf5e0f7fdd087c
parent355eb396904ac0635857fdd211ef2f726db19eb2 (diff)
Don't use boolean as identifier2.2.0.a1
Some headers/systems defined it as a macro.
-rw-r--r--odb/pgsql/query.cxx23
-rw-r--r--odb/pgsql/query.hxx16
2 files changed, 20 insertions, 19 deletions
diff --git a/odb/pgsql/query.cxx b/odb/pgsql/query.cxx
index 966df92..d02a195 100644
--- a/odb/pgsql/query.cxx
+++ b/odb/pgsql/query.cxx
@@ -156,7 +156,8 @@ namespace odb
void query_base::
append (const string& q)
{
- if (!clause_.empty () && clause_.back ().kind == clause_part::native)
+ if (!clause_.empty () &&
+ clause_.back ().kind == clause_part::kind_native)
{
string& s (clause_.back ().part);
@@ -173,7 +174,7 @@ namespace odb
s += q;
}
else
- clause_.push_back (clause_part (clause_part::native, q));
+ clause_.push_back (clause_part (clause_part::kind_native, q));
}
void query_base::
@@ -183,13 +184,13 @@ namespace odb
s += '.';
s += column;
- clause_.push_back (clause_part (clause_part::column, s));
+ clause_.push_back (clause_part (clause_part::kind_column, s));
}
void query_base::
add (details::shared_ptr<query_param> p, const char* conv)
{
- clause_.push_back (clause_part (clause_part::param));
+ clause_.push_back (clause_part (clause_part::kind_param));
if (conv != 0)
clause_.back ().part = conv;
@@ -292,12 +293,12 @@ namespace odb
//
clause_type::iterator i (clause_.begin ()), e (clause_.end ());
- if (i != e && i->kind == clause_part::boolean && i->bool_part)
+ if (i != e && i->kind == clause_part::kind_bool && i->bool_part)
{
clause_type::iterator j (i + 1);
if (j == e ||
- (j->kind == clause_part::native && check_prefix (j->part)))
+ (j->kind == clause_part::kind_native && check_prefix (j->part)))
clause_.erase (i);
}
}
@@ -309,7 +310,7 @@ namespace odb
{
const clause_part& p (clause_.front ());
- if (p.kind == clause_part::native && check_prefix (p.part))
+ if (p.kind == clause_part::kind_native && check_prefix (p.part))
return "";
return "WHERE ";
@@ -333,7 +334,7 @@ namespace odb
switch (i->kind)
{
- case clause_part::column:
+ case clause_part::kind_column:
{
if (last != ' ' && last != '(')
r += ' ';
@@ -341,7 +342,7 @@ namespace odb
r += i->part;
break;
}
- case clause_part::param:
+ case clause_part::kind_param:
{
if (last != ' ' && last != '(')
r += ' ';
@@ -366,7 +367,7 @@ namespace odb
break;
}
- case clause_part::native:
+ case clause_part::kind_native:
{
// We don't want extra spaces after '(' as well as before ','
// and ')'.
@@ -381,7 +382,7 @@ namespace odb
r += p;
break;
}
- case clause_part::boolean:
+ case clause_part::kind_bool:
{
if (last != ' ' && last != '(')
r += ' ';
diff --git a/odb/pgsql/query.hxx b/odb/pgsql/query.hxx
index 2a1c6b8..401f29a 100644
--- a/odb/pgsql/query.hxx
+++ b/odb/pgsql/query.hxx
@@ -93,15 +93,15 @@ namespace odb
{
enum kind_type
{
- column,
- param,
- native,
- boolean
+ kind_column,
+ kind_param,
+ kind_native,
+ kind_bool
};
clause_part (kind_type k): kind (k) {}
clause_part (kind_type k, const std::string& p): kind (k), part (p) {}
- clause_part (bool p): kind (boolean), bool_part (p) {}
+ clause_part (bool p): kind (kind_bool), bool_part (p) {}
kind_type kind;
std::string part; // If kind is param, then part is conversion expr.
@@ -126,14 +126,14 @@ namespace odb
query_base (const char* native)
: binding_ (0, 0), native_binding_ (0, 0, 0, 0)
{
- clause_.push_back (clause_part (clause_part::native, native));
+ clause_.push_back (clause_part (clause_part::kind_native, native));
}
explicit
query_base (const std::string& native)
: binding_ (0, 0), native_binding_ (0, 0, 0, 0)
{
- clause_.push_back (clause_part (clause_part::native, native));
+ clause_.push_back (clause_part (clause_part::kind_native, native));
}
query_base (const char* table, const char* column)
@@ -208,7 +208,7 @@ namespace odb
const_true () const
{
return clause_.size () == 1 &&
- clause_.front ().kind == clause_part::boolean &&
+ clause_.front ().kind == clause_part::kind_bool &&
clause_.front ().bool_part;
}